Skip to content

Block changes for migrated static and compendium pages#1237

Merged
dhee-tree merged 1 commit into
developfrom
feature/migrated-content
Jun 1, 2026
Merged

Block changes for migrated static and compendium pages#1237
dhee-tree merged 1 commit into
developfrom
feature/migrated-content

Conversation

@dhee-tree
Copy link
Copy Markdown
Contributor

What

https://officefornationalstatistics.atlassian.net/browse/DIS-4812

You can test for

  • Add warning message when updating migrated content for pages:
    • compendium_chapter
    • compendium_data
    • static_landing_page
    • static_page
    • static_article
    • static_qmi
    • static_foi
    • static_adhoc
    • static_methodology
    • static_methodology_download

How to review

  • port forward the api-router

  • run florence locally with make debug ENABLE_PERMISSION_API=true ENABLE_MIGRATION_FIELD=true

  • login with sandbox creds

  • Create collection, add migration link to a normal page

  • Create a new collection, edit the migrated content.

    • Try updating other fields (excluding migration link) and save/save and submit for review - you should get the warning message
    • Remove all changes, you should be able to save
    • You should be able to update the migration link
  • Adding a related link, uploading files, updating tables buttons should be blocked with a warning

  • Test scenarios

    • Add a migration link (no warnings)
    • Add a migration link with other content changed (warnings)
    • Review a migration link (no warnings)
    • Edit a migration link (no warnings)
    • Edit a migration link with other content changes.....(warnings)
    • Delete a migration link (no warnings)
    • Delete a migration link with other content changes....(warnings)

Who can review

!Me

@dhee-tree dhee-tree requested a review from a team as a code owner May 26, 2026 14:48
Copy link
Copy Markdown
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested it everything worked except for this scenario:

Delete a migration link with other content changes....(warnings) -

This one didn't give warnings. The page I used was this static_methodology:

http://localhost:8081/economy/grossvalueaddedgva/methodologies/planofproposedactionstoincreasethequalityandpublicvalueofregionalgrossvalueaddedstatistics

@dhee-tree dhee-tree force-pushed the feature/migrated-content branch from ce1b23b to 61a1911 Compare June 1, 2026 08:09
@cookel2 cookel2 self-requested a review June 1, 2026 10:07
Copy link
Copy Markdown
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all works for me now, thanks

@dhee-tree dhee-tree merged commit 61a1911 into develop Jun 1, 2026
9 checks passed
@dhee-tree dhee-tree deleted the feature/migrated-content branch June 1, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants